Skip to content

fix(@angular/cli): handle missing which binary in path #24036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Oct 7, 2022

This change updates the hasGlobalCliInstall logic so that a pending promise is not created.

Closes #23997

This change updates the `hasGlobalCliInstall` logic so that a pending promise is not created.

Closes angular#23997
@alan-agius4 alan-agius4 force-pushed the autocomplete-missing-which branch from e3711fb to 0cbb1d7 Compare October 7, 2022 11:59
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Oct 7, 2022
@alan-agius4 alan-agius4 requested a review from clydin October 7, 2022 12:04
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 7, 2022
@clydin clydin merged commit 4fa5b52 into angular:main Oct 7, 2022
@alan-agius4 alan-agius4 deleted the autocomplete-missing-which branch October 7, 2022 15:50
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

completion.ts: hasGlobalCliInstall requires "which"
2 participants