fix(@angular/cli): skip downloading temp CLI when running ng update without package names
#24028
Conversation
alan-agius4
added
action: review
alan-agius4
removed
the
action: review
… without package names In the case when `ng update` is ran without a package name, an update is not be performed. In this case using the current installed version of the CLI is good enough. Closes angular#24024
alan-agius4
force-pushed
the
update-temp-cli-no-packages
branch
from
380ac42 to
d26fe37
Compare
| fullMetadata: true, | ||
| ...npmrc, | ||
| ...(registry ? { registry } : {}), | ||
| }); | ||
|
|
||
| // TODO: find some way to test this |
There was a problem hiding this comment.
Not sure why this was here @clydin maybe you remember? This needs to be removed as otherwise certain errors are not fatal. Example: https://app.circleci.com/pipelines/github/angular/angular-cli/26850/workflows/10782a5e-36c3-4de6-ae85-0ebcfe456e4e/jobs/356140/parallel-runs/0/steps/0-105
The test previously failed because when trying to download the temp version of the CLI. This check is bypassed since pacote is not used.
There was a problem hiding this comment.
May have been leftover from before the package names were validated to be registry names.
alan-agius4
added
the
action: review
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
In the case when
ng updateis ran without a package name, an update is not be performed. In this case using the current installed version of the CLI is good enough.Closes #24024