Skip to content

feat(@schematics/angular): remove ngOnInit from component template #24008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

alan-agius4
Copy link
Collaborator

This commit removes the constructor and ngOnInit as most of the users prefer to add this manually if needed.

Closes #23678

@angular-robot angular-robot bot added the feature Issue that requests a new feature label Oct 4, 2022
This commit removes the `constructor` and `ngOnInit` as most of the users prefer to add this manually if needed.

Closes angular#23678
@alan-agius4 alan-agius4 marked this pull request as ready for review October 4, 2022 14:15
@alan-agius4 alan-agius4 requested a review from clydin October 4, 2022 14:15
@Brocco
Copy link
Contributor

Brocco commented Oct 4, 2022

I like this change!

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Oct 4, 2022
@clydin clydin merged commit 301b566 into angular:main Oct 4, 2022
@alan-agius4 alan-agius4 deleted the remove-on-init branch October 4, 2022 16:56
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker feature Issue that requests a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add flag to ng generate component that skips adding ngOnInit() interface.
3 participants