feat(@schematics/angular): Added --project-root option to the library schematic

[DariuszOstolski]

…hematics

PR Checklist

Please check to confirm your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Issue Number: 11927

What is the new behavior?

User is able to specify subdirectory in which new library is created

Does this PR introduce a breaking change?

• Yes
• No

Other information

[DariuszOstolski]

Frankly speaking I have no idea why e2e windows test fails with the following message:

Running test "tests/build/bundle-budgets.ts" (2 of 14 [1:16] (18/214))...
==========================================================================================
Running `ng "build"` [silent]...
CWD: X:\ramdisk\e2e-main\e2e-test\test-project
==========================================================================================
Running `ng "build"` [silent]...
CWD: X:\ramdisk\e2e-main\e2e-test\test-project
Test Process error Error: Process exit error - "cmd.exe /c ng build": 134...

STDOUT:


STDERR:
FATAL ERROR: v8::FromJust Maybe value is Nothing.
 1: 00007FF7D48DFD2F v8::internal::CodeObjectRegistry::~CodeObjectRegistry+112495
 2: 00007FF7D486EEF6 v8::internal::wasm::WasmCode::safepoint_table_offset+65526
 3: 00007FF7D486FDAD node::OnFatalError+301
 4: 00007FF7D51A13A5 v8::V8::FromJustIsNothing+53
 5: 00007FF7D478CA4A RSA_meth_get_flags+22266
 6: 00007FF7D478C8ED RSA_meth_get_flags+21917
 7: 00007FF7D4786C10 node::SetTracingController+52592
 8: 00007FF7D4933A32 uv_pipe_pending_type+4242
 9: 00007FF7D493E4D0 uv_loop_init+1024
10: 00007FF7D493E77A uv_run+202
11: 00007FF7D490D885 node::SpinEventLoop+309
12: 00007FF7D47A8570 v8::internal::wasm::SignatureMap::Freeze+35776
13: 00007FF7D47A3BC8 v8::internal::wasm::SignatureMap::Freeze+16920
14: 00007FF7D492EF5D uv_poll_stop+557
15: 00007FF7D57624B0 v8::internal::compiler::RepresentationChanger::Uint32OverflowOperatorFor+146416
16: 00007FFCD2E27974 BaseThreadInitThunk+20
17: 00007FFCD322A2F1 RtlUserThreadStart+33


    at _exec (C:\Users\circleci\ng\tests\legacy-cli\e2e\utils\process.ts:77:19)
    at silentNg (C:\Users\circleci\ng\tests\legacy-cli\e2e\utils\process.ts:266:12)
    at ng (C:\Users\circleci\ng\tests\legacy-cli\e2e\utils\process.ts:254:16)
    at default_1 (C:\Users\circleci\ng\tests\legacy-cli\e2e\tests\build\bundle-budgets.ts:30:47)
    at async C:\Users\circleci\ng\tests\legacy-cli\e2e\utils\test_process.ts:15:9


Test "tests/build/bundle-budgets" failed...
Process error - "C:\Users\circleci\ng\tests\legacy-cli\e2e\utils\run_test_process,C:/Users/circleci/ng/tests/legacy-cli/e2e/tests/build/bundle-budgets



Exited with code exit status 1

[alan-agius4]

Can you also add Closes: #11927 as part of the commit message footer as this issue fixes #11927 Thanks.

[DariuszOstolski]

Hi,

I'm not sure why tests failed on CircleCi, is there something I have to do on my branch?

The issue seems to be with node version, but this is out of scope of this pull request.

BR,
Dariusz

[alan-agius4]

Hi,

I'm not sure why tests failed on CircleCi, is there something I have to do on my branch?

The issue seems to be with node version, but this is out of scope of this pull request.

BR, Dariusz

I rebased the PR for you.

[alan-agius4]

One NIT, otherwise LGTM.

Please squash the commits.

[alan-agius4]

LGTM, thanks for your contribution.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}