fix(@angular-devkit/core): provide actionable warning when a workspace project has missing root property
#23473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
action: review
alan-agius4
force-pushed
the
root-validation-workspace
branch
from
58671d3 to
404383b
Compare
alan-agius4
force-pushed
the
root-validation-workspace
branch
from
2f633d7 to
404383b
Compare
alan-agius4
changed the title
root propertyroot property
alan-agius4
force-pushed
the
root-validation-workspace
branch
from
404383b to
6390944
Compare
alan-agius4
force-pushed
the
root-validation-workspace
branch
from
6390944 to
86e258d
Compare
…e project has missing `root` property The `root` property is required in a workspace project. Now we issue an actionable warning message when this is missing. Note: this will become an error in the next major version. Closes: angular#21310
alan-agius4
force-pushed
the
root-validation-workspace
branch
from
86e258d to
6f99294
Compare
|
@clydin PTAL |
clydin
approved these changes
Jul 8, 2022
clydin
reviewed
Jul 8, 2022
| // TODO: Diagnostic reporting support | ||
| // eslint-disable-next-line no-console | ||
| console.warn(message); |
There was a problem hiding this comment.
nit: Does the node provide location info? line/column info may be useful for fixing the underlying problem.
There was a problem hiding this comment.
It's actually a value, we can change this to be the actual Node quite easily, but I prefer if this was done in a separate PR.
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rootproperty is required in a workspace project. Now we issue an actionable warning message when this is missing.Note: this will become an error in the next major version.
Closes: #21310