Skip to content

refactor(@schematics/angular): move standalone component helpers to a private export for Angular components #23217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2022

Conversation

clydin
Copy link
Member

@clydin clydin commented May 25, 2022

The standalone component helper utilities introduced into the @angular/cdk via
angular/components#24931 have been added to an export path (private/components)
within @schematics/angular. The export path is primarily intended for the use of the components schematics
within @angular/cdk and @angular/material. The API exported from this path is not considered public API,
does not provide SemVer guarantees, and may be modified or removed without a deprecation cycle.

… private export for Angular components

The standalone component helper utilities introduced into the `@angular/cdk` via
angular/components#24931 have been added to an export path (`private/components`)
within `@schematics/angular`. The export path is primarily intended for the use of the components schematics
within `@angular/cdk` and `@angular/material`. The API exported from this path is not considered public API,
does not provide SemVer guarantees, and may be modified or removed without a deprecation cycle.
@clydin clydin added the target: rc This PR is targeted for the next release-candidate label May 25, 2022
@clydin clydin marked this pull request as ready for review May 25, 2022 14:12
@clydin clydin added this to the v14 milestone May 25, 2022
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label May 26, 2022
@dgp1130
Copy link
Collaborator

dgp1130 commented May 26, 2022

/cc @crisbeto

@dgp1130 dgp1130 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 26, 2022
@dgp1130 dgp1130 merged commit e895fc7 into angular:main May 26, 2022
@clydin clydin deleted the schematics/private/components branch May 26, 2022 18:39
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants