feat(@angular/cli): provide additional status messaging for ng add #19880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

alan-agius4 merged 1 commit into angular:master from clydin:ng-add-logging

Jan 28, 2021

Member

clydin commented Jan 26, 2021

This adds a spinner as well as shows more information regarding what package version was selected to be installed.

Closes #17983

clydin added the target: minor label

google-cla bot added the cla: yes label

clydin requested a review from alan-agius4

January 26, 2021 21:51

clydin force-pushed the ng-add-logging branch from 941ba8f to a6084c5 Compare

January 26, 2021 22:13

alan-agius4 reviewed

View reviewed changes

packages/angular/cli/commands/add-impl.ts Outdated Show resolved Hide resolved

alan-agius4 reviewed

View reviewed changes

packages/angular/cli/commands/add-impl.ts Outdated Show resolved Hide resolved

alan-agius4 reviewed

View reviewed changes

packages/angular/cli/commands/add-impl.ts Outdated Show resolved Hide resolved

alan-agius4 reviewed

View reviewed changes

packages/angular/cli/commands/add-impl.ts Outdated Show resolved Hide resolved

alan-agius4 reviewed

View reviewed changes

packages/angular/cli/commands/add-impl.ts Outdated Show resolved Hide resolved

alan-agius4 approved these changes

View reviewed changes

Collaborator

alan-agius4 left a comment •

edited

Loading

LGTM.

For consistence I would add a period at the end of the step.


          feat(@angular/cli): provide additional status messaging for ng add

93712e6

This adds a spinner as well as shows more information regarding what package version was selected to be installed.

Closes angular#17983

clydin force-pushed the ng-add-logging branch from 11badae to 93712e6 Compare

January 27, 2021 15:23

clydin added the action: merge label

alan-agius4 merged commit bd040bd into angular:master

clydin deleted the ng-add-logging branch

January 28, 2021 12:18

angular-automatic-lock-bot bot commented Feb 28, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

angular-automatic-lock-bot bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge target: minor