-
Notifications
You must be signed in to change notification settings - Fork 12k
refactor(@schematics/angular): remove unused buildDefaultPath #17597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
filipesilva
merged 2 commits into
angular:master
from
SchnWalter:remove-unused-build-default-path
May 18, 2020
Merged
refactor(@schematics/angular): remove unused buildDefaultPath #17597
filipesilva
merged 2 commits into
angular:master
from
SchnWalter:remove-unused-build-default-path
May 18, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
SchnWalter
commented
May 1, 2020
This was referenced May 2, 2020
jelbourn
pushed a commit
to angular/components
that referenced
this pull request
May 7, 2020
…hematics/angular` (#19229) The internal `project` file will be deleted with this change angular/angular-cli#17597, this copies that implementation to the file were it's needed.
jelbourn
pushed a commit
to angular/components
that referenced
this pull request
May 7, 2020
…hematics/angular` (#19229) The internal `project` file will be deleted with this change angular/angular-cli#17597, this copies that implementation to the file were it's needed.
alan-agius4
approved these changes
May 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
target: major
This PR is targeted for the next major release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@schematics/angular
package contains 2 functions that do the same thing, one of them is private and unused. The functions are both calledbuildDefaultPath()
.