Skip to content

refactor(@schematics/angular): remove unused buildDefaultPath #17597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 18, 2020
Merged

refactor(@schematics/angular): remove unused buildDefaultPath #17597

merged 2 commits into from
May 18, 2020

Conversation

SchnWalter
Copy link
Contributor

@SchnWalter SchnWalter commented May 1, 2020

The @schematics/angular package contains 2 functions that do the same thing, one of them is private and unused. The functions are both called buildDefaultPath().

@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label May 1, 2020
jelbourn pushed a commit to angular/components that referenced this pull request May 7, 2020
…hematics/angular` (#19229)

The internal `project` file will be deleted with this change angular/angular-cli#17597, this copies that implementation to the file were it's needed.
jelbourn pushed a commit to angular/components that referenced this pull request May 7, 2020
…hematics/angular` (#19229)

The internal `project` file will be deleted with this change angular/angular-cli#17597, this copies that implementation to the file were it's needed.
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed PR state: blocked labels May 18, 2020
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@filipesilva filipesilva merged commit e8fa77e into angular:master May 18, 2020
@SchnWalter SchnWalter deleted the remove-unused-build-default-path branch May 18, 2020 22:11
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants