fix(@schematics/angular): the ng-new schematic should not prompt for style nor for routing
#15207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahasall
force-pushed
the
fix-#13383
branch
2 times, most recently
from
8e98683 to
aed10da
Compare
ahasall
changed the title
ng-new schematic should not prompt for style nor routingng-new schematic should not prompt for style nor routing
ahasall
changed the title
ng-new schematic should not prompt for style nor routingng-new schematic should not prompt for style nor for routing
alan-agius4
reviewed
Jul 31, 2019
ahasall
force-pushed
the
fix-#13383
branch
2 times, most recently
from
d2ffe0e to
f9c389e
Compare
Splaktar
approved these changes
Aug 1, 2019
| @@ -307,6 +307,10 @@ export default function (options: ApplicationOptions): Rule { | |||
| } | |||
| validateProjectName(options.name); | |||
| options.prefix = options.prefix || 'app'; | |||
| // This line and the one above shouldn't be needed, but at the moment they are. | |||
| // This is because the default value defined in the schema.json file is not | |||
| // correctly set when this schematic is run from another schematic. | |||
There was a problem hiding this comment.
We should probably open an issue and add a link to it here w/ a TODO to remove this when that issue is resolved.
alan-agius4
approved these changes
Aug 1, 2019
kyliau
pushed a commit
that referenced
this pull request
Aug 2, 2019
kyliau
pushed a commit
that referenced
this pull request
Aug 2, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13383