test: add local npm registry to failing tests #15173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: major
clydin
approved these changes
Jul 26, 2019
| 'install', | ||
| '-g', | ||
| packages['@angular-devkit/schematics-cli'].tar, | ||
| '--unsafe-perm', |
There was a problem hiding this comment.
Same here for the package name.
Also, is unsafe-perm actually needed?
| const dir = await copyAssets(assetName); | ||
| process.chdir(dir); | ||
| if (!useNpmPackages) { | ||
| await useBuiltPackages(); |
There was a problem hiding this comment.
Technically, no test should be using the built packages directly anymore but this fixes the problem for now.
We should revisit these tests though. Potentially using npx to generate a new project of the appropriate version directly.
vikerman
pushed a commit
that referenced
this pull request
Jul 29, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.