Skip to content

fix(@angular-devkit/schematics): export task executor #12004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

qiyigg
Copy link
Contributor

@qiyigg qiyigg commented Aug 24, 2018

No description provided.

@qiyigg qiyigg requested a review from hansl August 24, 2018 22:26
@qiyigg qiyigg added the target: patch This PR is targeted for the next patch release label Aug 24, 2018
@clydin
Copy link
Member

clydin commented Aug 25, 2018

Not being imported is intentional. Those are only relevant to node environments.

@qiyigg
Copy link
Contributor Author

qiyigg commented Aug 25, 2018

@clydin My understanding is: Those are executors, which are necessary for external workflow. Especially, BuiltinTaskExecutor.RunSchematic should be useful for all workflows. If you'd prefer access the executors through tasks/node/index.ts, I'd suggest reverting the module_root change here(https://github.com/angular/angular-cli/blob/master/packages/angular_devkit/schematics/BUILD#L74)

@qiyigg
Copy link
Contributor Author

qiyigg commented Aug 27, 2018

This was done by #12008
Close this PR right now.

@qiyigg qiyigg closed this Aug 27, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants