fix(@angular-devkit/build-angular): remove inlining of font files #11763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inlining font files which are less than 10KB in CSS causes some issues; 1. Fonts get downloaded with the stylesheet rather than one first usage. Since CSS resources get downloaded lazily. 2. Differnt font files are used by different browsers. For instance `woff2` cannot be used by older `IOS`, which means extra data over the wire that cannot be used. 3. When using a lot of font variants and there are under 10Kb, it quickly adds up to the bundle size. 4. Considering also `HTTP2` not inlining recouces might be also be more befenifcial in some cases.
filipesilva
added
the
needs: discussion
|
Superseeded by #11826 |
hansl
removed
needs: discussion
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inlining font files which are less than 10kb in CSS causes some issues;
woff2cannot be used by olderIOS, which means extra data over the wire that cannot be used.HTTP2not inlining recouces might be also be more befenifcial in some cases.//cc @filipesilva & @clydin