Skip to content

fix(@angular-devkit/build-angular): do not break with Jasmine's mock clock #11627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2018

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Jul 23, 2018

Fixes #11164.
Fixes #11626.

@gkalpak gkalpak force-pushed the fix-build-angular-mock-clock branch from e649789 to c41a45c Compare July 23, 2018 14:49
@filipesilva filipesilva merged commit e17a2ed into angular:master Jul 23, 2018
@gkalpak gkalpak deleted the fix-build-angular-mock-clock branch July 23, 2018 16:03
@gkalpak
Copy link
Member Author

gkalpak commented Jul 26, 2018

@filipesilva, shouldn't this also be merged into the 6.1.x branch?
It is not included in the recent @angular-devkit/build-angular@0.7.0 😢

@filipesilva
Copy link
Contributor

It will be merged into 6.1.1, but 6.1.0 was already frozen except for release blocking commits.

@Manduro
Copy link
Contributor

Manduro commented Aug 13, 2018

@filipesilva This is not in 0.7.3/6.1.3 yet it seems, could you merge it for 6.1.x please?

@filipesilva
Copy link
Contributor

@Manduro looking into why that happened, it should be there but isn't.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@angular-devkit/build-angular breaks Jasmine's mock clock Regression: upgrading from 6.0.7 to 6.0.8 makes test fail
4 participants