Skip to content

fix(@angular/cli): do not remove schematics defaults with uppercase #10570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(@angular/cli): do not remove schematics defaults with uppercase #10570

wants to merge 1 commit into from

Conversation

cyrilletuzi
Copy link
Contributor

@cyrilletuzi
Copy link
Contributor Author

cyrilletuzi commented May 1, 2018

I don't understand the failure in travis, there's no reason my small change caused this (if it was, the HTML file should be missing too), and I can't reproduce the error on a local project (when doing ng g component test with no defaults, the css file is correctly created). So not sure it's related.

Brocco added a commit to Brocco/angular-cli that referenced this pull request May 1, 2018
@Brocco
Copy link
Contributor

Brocco commented May 1, 2018

Closing this in favor of #10586 due to timing.

Also a cleaner import for the string utilities and an included tests.

Thank you for reporting this and providing this PR which I based my changes off of, totally appreciate it!

@Brocco Brocco closed this May 1, 2018
Brocco added a commit to Brocco/angular-cli that referenced this pull request May 2, 2018
@cyrilletuzi cyrilletuzi deleted the defaultscamelize branch May 2, 2018 07:16
hansl pushed a commit that referenced this pull request May 2, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default schematics options with uppercase doesn't work
3 participants