PostCSS handling of absolute deployUrl paths

[andrewtaylor]

When a deployUrl consists of an absolute path, it needs to be prepended to the outputUrl since url.resolve will just ignore it. The proposed patch simply checks for an absolute path to perform a prepend, falling back to the existing logic otherwise.

Without this patch resources within stylesheets do not get their paths prefixed with the deployUrl if for example that deployUrl is "/static".

[clydin]

This is operating as intended. /static and /static/ have two different meanings. The deployUrl, if used (base href is generally the more appropriate option), should end in a / if the last segment represents a directory and not a file.

[andrewtaylor]

Setting to /static/ does fix it. However given the context of a deployUrl, it can only be a directory. Hence is there not a reasonable expectation that it either warns about a missing slash or adds it itself? It seems other parts of the code do the latter, for example

angular-cli/packages/@angular/cli/models/webpack-configs/styles.ts

Line 113 in e48d545

return `${deployUrl.replace(/\/$/, '')}${url}`;

.

[clydin]

There's a more in-depth discussion on the deployUrl option in this PR: #8740.

If the goal is to normalize the deploy URL to always refer to a directory, then similar code to the above linked PR should be placed after this line in the configuration builder: https://github.com/angular/angular-cli/blob/1.7.x/packages/%40angular/cli/models/webpack-config.ts#L41

As an aside, in general, anywhere that someone attempts to use deploy URL, they should be using the base href option instead. For a comparison, see here: https://github.com/angular/angular-cli/blob/master/docs/design/deployurl-basehref.md

[andrewtaylor]

You are correct, I was looking for the "more complicated setup" with baseHref "/static/" and APP_BASE_HREF "/". Thanks for that link explaining the difference..

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}