Schematics: addRouteDeclarationToModule

[israelpasos]

🐞 Bug report

Command (mark with an x)

- [ ] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [X] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Is this a regression?

No

Description

addRouteDeclarationToModule in angular-cli/packages/schematics/angular/utility/ast-utils.ts. Adds the route literal within guard arrays.

Original Routes[]:

const routes: Routes = [{
      path: 'admin',
      loadChildren: () => import('src/app/bvs-ppa/admin/admin.module').then(m => m.AdminModule),
      canActivate: [AdminGuard],
      canActivateChild: [AdminGuard],
      canLoad: [AdminGuard]
    }];

After addRouteDeclarationToModule:

const routes: Routes = [{
      path: 'admin',
      loadChildren: () => import('src/app/bvs-ppa/admin/admin.module').then(m => m.AdminModule),
      canActivate: [AdminGuard],
      canActivateChild: [AdminGuard],
      canLoad: [, {
      path: 'technical',
      loadChildren: () => import('src/app/bvs-ppa/technical/technical.module').then(m => m.TechnicalModule),
      canActivate: [TechnicalGuard],
      canActivateChild: [TechnicalGuard],
      canLoad: [TechnicalGuard]
    }AdminGuard]
    }];

Expected:

const routes: Routes = [{
      path: 'admin',
      loadChildren: () => import('src/app/bvs-ppa/admin/admin.module').then(m => m.AdminModule),
      canActivate: [AdminGuard],
      canActivateChild: [AdminGuard],
      canLoad: [AdminGuard]
    },
    {
      path: 'technical',
      loadChildren: () => import('src/app/bvs-ppa/technical/technical.module').then(m => m.TechnicalModule),
      canActivate: [TechnicalGuard],
      canActivateChild: [TechnicalGuard],
      canLoad: [TechnicalGuard]
    }
  ];

🌍 Your Environment

Angular CLI: 8.0.6
Node: 10.15.3
OS: darwin x64
Angular: 8.0.3
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router

Package Version

@angular-devkit/architect 0.800.6
@angular-devkit/build-angular 0.800.6
@angular-devkit/build-optimizer 0.800.6
@angular-devkit/build-webpack 0.800.6
@angular-devkit/core 8.0.6
@angular-devkit/schematics 8.0.6
@angular/cdk 8.0.1
@angular/cli 8.0.6
@angular/material 8.0.1
@ngtools/webpack 8.0.6
@schematics/angular 8.0.6
@schematics/update 0.800.6
rxjs 6.4.0
typescript 3.4.5
webpack 4.30.0