feat(@angular-devkit/build-angular): add wildcard option for allowedCommonJsDependencies

This commit adds the functionality to that when a wildcard `*` is provided to `allowedCommonJsDependencies` CJS/AMD warnings usages is skipped.

Closes #25784

Author: domske

packages/angular_devkit/build_angular/src/builders/application/schema.json

@@ -406,7 +406,7 @@
       "enum": ["none", "anonymous", "use-credentials"]
     },
     "allowedCommonJsDependencies": {
-      "description": "A list of CommonJS packages that are allowed to be used without a build time warning.",
+      "description": "A list of CommonJS or AMD packages that are allowed to be used without a build time warning. Use `'*'` to allow all.",
       "type": "array",
       "items": {
         "type": "string"

packages/angular_devkit/build_angular/src/builders/application/tests/options/allowed-common-js-dependencies_spec.ts

@@ -77,7 +77,7 @@ describeBuilder(buildApplication, APPLICATION_BUILDER_INFO, (harness) => {
       );
     });
 
-    it('should not show warning when all dependencies are allowed by asterisk', async () => {
+    it('should not show warning when all dependencies are allowed by wildcard', async () => {
       // Add a Common JS dependency
       await harness.appendToFile(
         'src/app/app.component.ts',

packages/angular_devkit/build_angular/src/builders/browser-esbuild/schema.json

@@ -429,7 +429,7 @@
       "enum": ["none", "anonymous", "use-credentials"]
     },
     "allowedCommonJsDependencies": {
-      "description": "A list of CommonJS packages that are allowed to be used without a build time warning.",
+      "description": "A list of CommonJS or AMD packages that are allowed to be used without a build time warning. Use `'*'` to allow all.",
       "type": "array",
       "items": {
         "type": "string"

packages/angular_devkit/build_angular/src/builders/browser/schema.json

@@ -417,7 +417,7 @@
       "enum": ["none", "anonymous", "use-credentials"]
     },
     "allowedCommonJsDependencies": {
-      "description": "A list of CommonJS packages that are allowed to be used without a build time warning.",
+      "description": "A list of CommonJS or AMD packages that are allowed to be used without a build time warning. Use `'*'` to allow all.",
       "type": "array",
       "items": {
         "type": "string"

packages/angular_devkit/build_angular/src/builders/browser/tests/options/allowed-common-js-dependencies_spec.ts

@@ -71,7 +71,7 @@ describeBuilder(buildWebpackBrowser, BROWSER_BUILDER_INFO, (harness) => {
       );
     });
 
-    it('should not show warning when all dependencies are allowed by asterisk', async () => {
+    it('should not show warning when all dependencies are allowed by wildcard', async () => {
       // Add a Common JS dependency
       await harness.appendToFile(
         'src/app/app.component.ts',

packages/angular_devkit/build_angular/src/tools/esbuild/commonjs-checker.ts

@@ -17,7 +17,7 @@ import type { Metafile, PartialMessage } from 'esbuild';
  *
  * If any allowed dependencies are provided via the `allowedCommonJsDependencies`
  * parameter, both the direct import and any deep imports will be ignored and no
- * diagnostic will be generated. Use `'*'` as entry to allow all dependencies.
+ * diagnostic will be generated. Use `'*'` as entry to skip the check.
  *
  * If a module has been issued a diagnostic message, then all descendant modules
  * will not be checked. This prevents a potential massive amount of inactionable
@@ -34,6 +34,10 @@ export function checkCommonJSModules(
   const messages: PartialMessage[] = [];
   const allowedRequests = new Set(allowedCommonJsDependencies);
 
+  if (allowedRequests.has('*')) {
+    return messages;
+  }
+
   // Ignore Angular locale definitions which are currently UMD
   allowedRequests.add('@angular/common/locales');
 
@@ -83,7 +87,7 @@ export function checkCommonJSModules(
         const request = imported.original;
 
         let notAllowed = true;
-        if (allowedRequests.has('*') || allowedRequests.has(request)) {
+        if (allowedRequests.has(request)) {
           notAllowed = false;
         } else {
           // Check for deep imports of allowed requests

packages/angular_devkit/build_angular/src/tools/webpack/plugins/common-js-usage-warn-plugin.ts

@@ -17,7 +17,7 @@ const CommonJsRequireDependency = require('webpack/lib/dependencies/CommonJsRequ
 const CommonJsSelfReferenceDependency = require('webpack/lib/dependencies/CommonJsSelfReferenceDependency');
 
 export interface CommonJsUsageWarnPluginOptions {
-  /** A list of CommonJS packages that are allowed to be used without a warning. */
+  /** A list of CommonJS or AMD packages that are allowed to be used without a warning. Use `'*'` to allow all. */
   allowedDependencies?: string[];
 }
 
@@ -30,6 +30,10 @@ export class CommonJsUsageWarnPlugin {
   }
 
   apply(compiler: Compiler) {
+    if (this.allowedDependencies.has('*')) {
+      return;
+    }
+
     compiler.hooks.compilation.tap('CommonJsUsageWarnPlugin', (compilation) => {
       compilation.hooks.finishModules.tap('CommonJsUsageWarnPlugin', (modules) => {
         const mainEntry = compilation.entries.get('main');