feat(@Angular-devkit): asterisk option for allowedCommonJsDependencies

Author: domske

packages/angular_devkit/build_angular/src/builders/application/tests/options/allowed-common-js-dependencies_spec.ts

@@ -77,6 +77,31 @@ describeBuilder(buildApplication, APPLICATION_BUILDER_INFO, (harness) => {
       );
     });
 
+    it('should not show warning when all dependencies are allowed by asterisk', async () => {
+      // Add a Common JS dependency
+      await harness.appendToFile(
+        'src/app/app.component.ts',
+        `
+        import 'buffer';
+      `,
+      );
+
+      harness.useTarget('build', {
+        ...BASE_OPTIONS,
+        allowedCommonJsDependencies: ['*'],
+        optimization: true,
+      });
+
+      const { result, logs } = await harness.executeOnce();
+
+      expect(result?.success).toBe(true);
+      expect(logs).not.toContain(
+        jasmine.objectContaining<logging.LogEntry>({
+          message: jasmine.stringMatching(/CommonJS or AMD dependencies/),
+        }),
+      );
+    });
+
     it('should not show warning when depending on zone.js', async () => {
       // Add a Common JS dependency
       await harness.appendToFile(

packages/angular_devkit/build_angular/src/builders/browser/tests/options/allowed-common-js-dependencies_spec.ts

@@ -71,6 +71,31 @@ describeBuilder(buildWebpackBrowser, BROWSER_BUILDER_INFO, (harness) => {
       );
     });
 
+    it('should not show warning when all dependencies are allowed by asterisk', async () => {
+      // Add a Common JS dependency
+      await harness.appendToFile(
+        'src/app/app.component.ts',
+        `
+        import 'bootstrap';
+        import 'zone.js';
+      `,
+      );
+
+      harness.useTarget('build', {
+        ...BASE_OPTIONS,
+        allowedCommonJsDependencies: ['*'],
+      });
+
+      const { result, logs } = await harness.executeOnce();
+
+      expect(result?.success).toBe(true);
+      expect(logs).not.toContain(
+        jasmine.objectContaining<logging.LogEntry>({
+          message: jasmine.stringMatching(/CommonJS or AMD dependencies/),
+        }),
+      );
+    });
+
     it(`should not show warning when importing non global local data '@angular/common/locale/fr'`, async () => {
       await harness.appendToFile(
         'src/app/app.component.ts',

packages/angular_devkit/build_angular/src/tools/esbuild/commonjs-checker.ts

@@ -17,7 +17,7 @@ import type { Metafile, PartialMessage } from 'esbuild';
  *
  * If any allowed dependencies are provided via the `allowedCommonJsDependencies`
  * parameter, both the direct import and any deep imports will be ignored and no
- * diagnostic will be generated.
+ * diagnostic will be generated. Use `'*'` as entry to allow all dependencies.
  *
  * If a module has been issued a diagnostic message, then all descendant modules
  * will not be checked. This prevents a potential massive amount of inactionable
@@ -83,7 +83,7 @@ export function checkCommonJSModules(
         const request = imported.original;
 
         let notAllowed = true;
-        if (allowedRequests.has(request)) {
+        if (allowedRequests.has('*') || allowedRequests.has(request)) {
           notAllowed = false;
         } else {
           // Check for deep imports of allowed requests