This repository was archived by the owner on Sep 8, 2020. It is now read-only.
Allow for updates to the sortable options #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I $observe the attrs for changes and update the options. This enables you to update the options on the fly. Example being enabling and disabling the ability to sort, during an "edit" action.
|
|
||
| opts = angular.extend({}, uiSortableConfig, scope.$eval(attrs.uiSortable)); | ||
| attrs.$observe('ui-sortable', function(){ | ||
| opts = angular.extend({}, uiSortableConfig, scope.$eval(attrs.uiSortable)); |
There was a problem hiding this comment.
This can be changed to simply:
angular.extend(opts, uiSortableConfig, scope.$eval(attrs.uiSortable));
ProLoser
added a commit
that referenced
this pull request
May 21, 2013
Allow for updates to the sortable options
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I $observe the attrs for changes and update the options. This enables you to update the options on the fly.
Example being enabling and disabling the ability to sort, during an "edit" action.