This repository was archived by the owner on Sep 8, 2020. It is now read-only.
Perf Improvement: don't digest after the $timeout. #292
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Gratz for finding this. 👍 |
|
Also, possibly fixes/improves #288. |
thgreasi
added a commit
that referenced
this pull request
Nov 8, 2014
feat(sortable): remove digest from $timeout on sortable('refresh')
|
Thanks for spotting this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, the
$timeoutin the directive does not actually modify any code that would require a$digest, although$timeoutautomatically calls digest at the end of the function.This causes unnecessary digests to happen too frequently on startup (when I have several
ui-sortabledirectives), affecting my startup performance.It seems to work to call
$timeout(callbac, 0, false)which forgoes the$digestbut everything still works.I there any reason that this won't work in your
linkfunction?