Skip to content
This repository was archived by the owner on Sep 8, 2020. It is now read-only.

Update demo case #269

Merged
merged 2 commits into from
Nov 15, 2014
Merged

Update demo case #269

merged 2 commits into from
Nov 15, 2014

Conversation

walkingice
Copy link
Contributor

  • make the demo page responsive
  • add case to demo connected-list feature

instead of using hard-coded style, involve bootstrap responsive design.

Since already use bootstrap to demo page, we could layout components
by boostrap classes to instead of using hard-coded width.
connected list is also a good feature of ui-sortable.
add one more case to demo.
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling ca52269 on walkingice:master into 57c5332 on angular-ui:master.

@thgreasi
Copy link
Contributor

Sorry it took me so long to respond and thanks for this commit 👍
Is there a reason that the log title was removed from the .logList?

 .logList:before {
-   content: 'log';
-   padding: 0 5px;
-   position: relative;
-   top: -1.1em;
    background-color: #FFF;
 }

In my tests the new fitting value for top should be about -1.7em.
If you insist on your changes, then please remove .logList:before altogether.

@thgreasi
Copy link
Contributor

Also please note (I don't know if it is intentional), that the user will be able to drag elements from the "connected lists" to the "simple list".
I would prefer adding a unique class per example case container/section/row and scoping the connectWith css selector like: '.connectedListsExample .list'.

@thgreasi thgreasi merged commit ca52269 into angular-ui:master Nov 15, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants