Callback fix and code cleanup

[aloise]

It's a workaround for user dynamic callbacks bug. It preserves default callbacks and cleans some duplicate callback initialization code. Hopefully it will save a day for someone.

[nedbaldessin]

(Tested with AngularJS 1.1.5)

This indeed fixes the callback bug (if you specified a callback, the internal function being composed was never called).

But if in the callback I check the order of elements in the model, they are ordered as they were before the reordering action.

Example
Initial order: [1, 2, 3]
…drag and drop, put the third element in second position…
in update callback, output the model elements, the result is: [1, 2, 3]
…drag and drop, put the third element in first position…
result is: [1, 3, 2]
etc…

[aloise]

I believe it's fine. You should use the "stop" callback in your case. Update is triggered once the DOM position was changed. The angular model is updated in the "stop" callback. The same behavior was introduced in the original ui-sortable and I just follow this behavior.

[nedbaldessin]

Ah, you are right, I should have been using the "stop" callback. Thanks a lot!