Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

fix dragleave triggered on children #741

Merged
merged 1 commit into from
Mar 17, 2015

Conversation

0xF013
Copy link
Contributor

@0xF013 0xF013 commented Mar 10, 2015

No description provided.

@dimirc
Copy link
Contributor

dimirc commented Mar 11, 2015

What error/issue was this causing?

@0xF013
Copy link
Contributor Author

0xF013 commented Mar 11, 2015

@dimirc in some cases dragging a choice over another causes the whole drag process to cancel out. Should I prepare some examples?

@dimirc
Copy link
Contributor

dimirc commented Mar 11, 2015

One example will be helpful to check this

dimirc added a commit that referenced this pull request Mar 17, 2015
@dimirc dimirc merged commit 90d2617 into angular-ui:master Mar 17, 2015
@0xF013
Copy link
Contributor Author

0xF013 commented Mar 23, 2015

@dimirc I am sorry, I might have introduced some side effects with this fix, mainly dragleave not being consistently fired. The problem I actually had got easily fixed with

.select2-choices li * {
  pointer-events: none;
}

which was either not set or overwritten by some other css.

@dimirc
Copy link
Contributor

dimirc commented Mar 24, 2015

Do you mean this commit should better be reverted then?

Sent from my iPhone

On Mar 23, 2015, at 6:21 AM, Mihail Maxacov notifications@github.com wrote:

@dimirc I am sorry, I might have introduced some side effects with this fix, mainly dragleave not being consistently fired. The problem I actually had got easily fixed with

.select2-choices li * {
pointer-events: none;
}
which was either not set or overwritten by some other css.


Reply to this email directly or view it on GitHub.

@0xF013
Copy link
Contributor Author

0xF013 commented Mar 25, 2015

@dimirc yes please, I fixed the issue without looking into the cause

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants