Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

fix for single select with simple tags #671

Merged
merged 1 commit into from
Feb 18, 2015

Conversation

brianfeister
Copy link

No description provided.

@brianfeister brianfeister added this to the 0.9.9 milestone Feb 16, 2015
@dimirc
Copy link
Contributor

dimirc commented Feb 16, 2015

You shouldn't change /dist files but /src

@brianfeister
Copy link
Author

whew, good catch, my fault for not noticing they were in the wrong spot when I opened the PR. @trickpattyFH20, great if you can push a commit out to your fork that removes this change from /dist/select.js and adds it to /src/select.js

@trickpattyFH20
Copy link
Contributor

@brianfeister Sorry! I moved the changes from dist to src.

Looks like the build doesn't like "== null" and it wants me to use "=== null" but using triple equals does not work... still gets "Cannot read property 'toUpperCase' of undefined" unless you use just a double equals...

I changed the fix to use === undefined rather than ==null

@dimirc
Copy link
Contributor

dimirc commented Feb 17, 2015

Will be also better of you could squash commits to try keeping master as clean as possible

@trickpattyFH20
Copy link
Contributor

@brianfeister everything is moved out of dist and into src.
@dimirc I squashed the commits into one and it's ready to go.

@dimirc
Copy link
Contributor

dimirc commented Feb 18, 2015

@brianfeister I'm not familiar with all the tagging functionality yet. As you created this PR, can you confirm if its ok and merge it to be able to ship it with next release?

@dimirc dimirc added the tagging label Feb 18, 2015
brianfeister pushed a commit that referenced this pull request Feb 18, 2015
fix for single select with simple tags
@brianfeister brianfeister merged commit 30b00af into angular-ui:master Feb 18, 2015
@brianfeister
Copy link
Author

Thanks @trickpattyFH20, it will be in the next release. Looks like @dimirc is on a roll merging PR's and reviewing things, I'll leave it to him to determine the next release.

@dimirc
Copy link
Contributor

dimirc commented Feb 18, 2015

v0.9.9 released

Sent from my iPhone

On Feb 17, 2015, at 10:20 PM, Brian Feister notifications@github.com wrote:

Thanks @trickpattyFH20, it will be in the next release. Looks like @dimirc is on a roll merging PR's and reviewing things, I'll leave it to him to determine the next release.


Reply to this email directly or view it on GitHub.

Asimov4 pushed a commit to Asimov4/ui-select that referenced this pull request Mar 8, 2015
Asimov4 pushed a commit to Asimov4/ui-select that referenced this pull request Mar 8, 2015
Asimov4 pushed a commit to Asimov4/ui-select that referenced this pull request Mar 17, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants