Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

fix(bootstrap): allow-clear style #667

Merged
merged 5 commits into from
Feb 16, 2015
Merged

fix(bootstrap): allow-clear style #667

merged 5 commits into from
Feb 16, 2015

Conversation

dimirc
Copy link
Contributor

@dimirc dimirc commented Feb 16, 2015

  • Fix Firefox alignment
  • Clicking the X icon on Firefox isn't working

Demo plunker

JeromeLam and others added 2 commits February 16, 2015 08:51
Remove the outline and box shadow that comes with the btn class.
Add btn-link CSS class for Bootstrap clear button.
@starf
Copy link

starf commented Feb 16, 2015

Thanks for the fix.
For the love of god, merge this.
It probably deserves a release on it's own.

@dimirc
Copy link
Contributor Author

dimirc commented Feb 16, 2015

Have you checked in firefox ? It seems that the clear button is still below the drop down, however now, it's on the right side.

As @gzsombor reported, there's an issue still with firefox

image

@dimirc
Copy link
Contributor Author

dimirc commented Feb 16, 2015

Alignment on Firefox is fixed with last commit. Updated plunker

Now a new problem in firefox is that clicking on the X icon isnt working. I suspect it might be something similar as #196

@dimirc
Copy link
Contributor Author

dimirc commented Feb 16, 2015

Clicking on X icon solved on Firefox. Updated plunker

dimirc added a commit that referenced this pull request Feb 16, 2015
@dimirc dimirc merged commit 69d6244 into master Feb 16, 2015
@dimirc dimirc deleted the fix-allow-clear-bs branch February 16, 2015 23:13
@dimirc dimirc added this to the 0.9.9 milestone Feb 16, 2015
@abobwhite
Copy link

@dimirc Thanks!
@starf Couldn't have said it better myself!

@dimirc dimirc mentioned this pull request Feb 17, 2015
@khalilst
Copy link

khalilst commented Apr 29, 2017

I used allowClear: true in js and allow-clear in html. None of them works. Any idea?
I'm using select2 latest version [4.0.3].

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants