Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

Support multiple="multiple" attribute. #407

Merged
merged 2 commits into from
Nov 21, 2014
Merged

Support multiple="multiple" attribute. #407

merged 2 commits into from
Nov 21, 2014

Conversation

ctavan
Copy link
Contributor

@ctavan ctavan commented Nov 18, 2014

Some html preprocessors will transform

<ui-select multiple></ui-select>

into

<ui-select multiple="multiple"></ui-select>

which is currently not supported by angular-ui-select. This patch fixes the issue.

@amcdnl
Copy link
Contributor

amcdnl commented Nov 18, 2014

Can you write a test please?

Some html preprocessors will transform

<ui-select multiple></ui-select>

into

<ui-select multiple="multiple"></ui-select>

which is currently not supported by angular-ui-select. This patch fixes the
issue.
@ctavan
Copy link
Contributor Author

ctavan commented Nov 18, 2014

There you go. I also rebased again.

@ctavan
Copy link
Contributor Author

ctavan commented Nov 21, 2014

Is there still something I can do for this patch to get merged?

amcdnl added a commit that referenced this pull request Nov 21, 2014
@amcdnl amcdnl merged commit c1f8c29 into angular-ui:master Nov 21, 2014
@amcdnl
Copy link
Contributor

amcdnl commented Nov 21, 2014

Merged.

@ctavan ctavan deleted the allow-multiple-multiple-attribute branch December 17, 2014 18:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants