This repository was archived by the owner on Oct 2, 2019. It is now read-only.
Added closeOnSelect attribute #362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The unit test was failing already. Not related to my change. |
|
@travistx I fixed the failing test if you update. |
|
@travistx - merged, thanks for the PR! I've been wanting to add this myself! |
|
@travistx there is actually a bug with this; if I open a dropdown and then directly open another one they first one does not close causing both selects to be open. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #339: Prevent dropdown close on selection with multiple attribute.
It provides a new configuration attribute close-on-select="false", and a new uiSelectConfig property closeOnSelect.