Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

Display placeholder when searchEnable is set to false #241 #317

Merged
merged 2 commits into from
Oct 29, 2014

Conversation

hthabet
Copy link
Contributor

@hthabet hthabet commented Oct 16, 2014

fixes issue with displaying placeholder when searchEnable is set to false [#241]

@hthabet hthabet changed the title fixes issue with displaying placeholder when searchEnable is set to fals... fixes issue #241 Oct 16, 2014
@hthabet hthabet force-pushed the fix_placeholderWhenSearchFalse branch from 7d4ec9b to d69dc3d Compare October 16, 2014 15:23
@hthabet hthabet changed the title fixes issue #241 Display placeholder when searchEnable is set to false #241 Oct 16, 2014
@dimirc
Copy link
Contributor

dimirc commented Oct 17, 2014

Can you remove the change to package.json?

@hthabet
Copy link
Contributor Author

hthabet commented Oct 17, 2014

@dimirc I rollbacked the change

dimirc added a commit that referenced this pull request Oct 29, 2014
Display placeholder when searchEnable is set to false #241
@dimirc dimirc merged commit e277a1c into angular-ui:master Oct 29, 2014
@jmonterroso
Copy link

This is not working in the latest version downloaded from bower, was this behavior not merged yet?

@dtomaszewski
Copy link

+1

1 similar comment
@evelez
Copy link

evelez commented Feb 13, 2015

+1

@dimirc
Copy link
Contributor

dimirc commented Feb 13, 2015

@dtomaszewski @evelez are can you setup a plunker to check this? what version of the lib are you using?

@hkorutla
Copy link

+1

@hkorutla
Copy link

I still have the same issue with "selectize" theme when search-enabled=false, placeholder is hiding. Any help would be appreciated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants