Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

fix(uiSelectMultipleDirective): add $isEmpty handler #1492

Merged
merged 1 commit into from
Mar 16, 2016

Conversation

kmccullough
Copy link

Fixes #850

aaronroberson added a commit that referenced this pull request Mar 16, 2016
fix(uiSelectMultipleDirective): add $isEmpty handler

Fixes #850
@aaronroberson aaronroberson merged commit 161cff5 into angular-ui:master Mar 16, 2016
@aaronroberson
Copy link
Contributor

@kmccullough Thanks, this will land in the next release!

@tmanoel
Copy link

tmanoel commented Aug 8, 2016

Using single select and it's not working yet.. I'm Using version 0.19.0

@kmccullough kmccullough deleted the multipleIsEmpty branch August 8, 2016 18:13
@kmccullough
Copy link
Author

@tmanoel I'm not sure what you are expecting. This fix is for ng-required not working on multiple selection. It should already work for single.

@tmanoel
Copy link

tmanoel commented Aug 8, 2016

Thanks for the attention, kmccullough. But I'm using it into a directive. I've tried use required and ng-requeired, still not working for single select.

@tmanoel
Copy link

tmanoel commented Aug 9, 2016

Take a look, it doesnt work on single neither multiple..
http://plnkr.co/edit/5Zt0OfEFh18tlcKP1Yen?p=preview

@kmccullough
Copy link
Author

Can you give us a better idea of exactly what you are expecting in that plunkr @tmanoel ? It appears you are using version 0.11.2 of ui-select, which you have copied to an actual file included with the page, but it does not include my fix from this commit. Please try the latest version via CDN, update your sources with the latest, or apply my fix from src/uiSelectMultipleDirective.js to your own sources.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants