This repository was archived by the owner on Oct 2, 2019. It is now read-only.
Add tests for #107 #108
Merged
Add tests for #107 #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good. Can you add tests for changes from model to view? I mean changing the scope should make control to select the correct object as selected value in case it has an specific property or the whole object |
|
Good point, I forgot about that way as well. Tests are added now. |
|
@SimeonC thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added tests for three scenarios I came up with: "person.name as person in people", "person as person in people" and "person in people".
Also I modified your package.json to add a postinstall (runs
bower installafternpm install) and test script (means thatnpm testwill rungulp test) - they're helpful for contributors getting started with minimum fuss.