$state.reload() should reinitialize the controller

[ghengeveld]

As discussed in #76, $state.reload() does reload the resolves, but doesn't reinitialize the controller with the newly resolved values. Since the whole point of reloading the resolves is to refresh the scope with the new data, reinitializing the controller is a requirement for $state.reload() to be of any use.

Demo: http://plnkr.co/edit/GNr1bN?p=preview

[mfield]

I don't know whether this behavior is intentional or not. In my application, I skirted this issue by setting a $watch on the values in $state like http://plnkr.co/edit/DVFG8T?p=preview

[ghengeveld]

Good to see there is a workaround. Still, it does make sense to reload the controller too so it resets it's state. Besides, using $state.$current.locals.globals circumvents the DI syntax for resolved properties, which makes it a lot less explicit (and explicit DI is what makes it so nice and simple).

[laurelnaiad]

I haven't checked but if reload induces stateChangeSuccess then that would be better than watching if you're watching just so you can track reload-based changes.

[tamtakoe]

👍

[panga]

I agree with @ghengeveld, $state.reload() also should reinitialize the controllers to refresh scope.

[nateabele]

Yup, agreed, sorry for overlooking that. It'll get fixed as soon as I have time.

[lc-nyovchev]

👍

[johnculviner]

👍 Anyone know another workaround for this? I'm building out a massive SPA and I need each of the controllers (all different routes) to refresh when the user changes a drop down that is part of the surrounding chrome of the SPA. Right now it looks like I have to write a bunch of code in each controller which is going to be bad. Thanks!

[appglu-devinpoolman]

Have you tried flipping the reload flag on transitionTo?

        $state.transitionTo($state.current, $stateParams, { reload: true, inherit: false, notify: true });

[johnculviner]

Thanks for the thought. I gave it a shot but to no avail...

I even tried changing:

  function shouldTriggerReload(to, from, locals, options) {
    if ( to === from && ((locals === from.locals) || (to.self.reloadOnSearch === false)) ) {
      return true;
    }
  }

To:

function shouldTriggerReload(to, from, locals, options) {

    if(options.reload) {
        return true;
    }

    if ( to === from && ((locals === from.locals) || (to.self.reloadOnSearch === false)) ) {
      return true;
    }
  }

Because it was returning false when options.reload == true (which didn't make sense to me) but that didn't work either. Bummer! I'm gonna have to put watches on a broadcast for that "global drop down change" I guess until this is resolved or I can figure it out on my own time. UI Router is AMAZING otherwise though. I recommend it over the built in Angular one whenever I talk or present on Angular!

[zakjan]

What is state of this bug?

[nateabele]

@zakjan Hope to have a fix pushed by this weekend.

[johnculviner]

👍 Sweet, pumped for this as it should clean up the code on a few of my pages quite significantly. Thanks!