-
Notifications
You must be signed in to change notification settings - Fork 134
chore(update) update some dev dependencies #76
Conversation
"karma-chrome-launcher": "^0.1.8", | ||
"karma-coffee-preprocessor": "^0.2.1", | ||
"karma-coverage": "^0.3.1", | ||
"karma": "0.13.14", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is karma completing fast? One of the reasons it was being held back to 0.12.X was because 0.13.X was slow in grunt. I know in gulp it is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did test on my PC, Ubuntu 15.10 x64 - Intel Core i5, and it is
reasonably fast, but on travis is slowly, Should I revert?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it is fine. Took 2.413 secs / 2.658 secs
fast for me. The only thing that is slow, is travis is a fresh install of binaries of npm and bower.
@elesdoar no need to revert. lol |
Go back to sha 31422ce |
|
Sorry, test on karma 0.12, You are right, is faster than 0.13. |
No need to be sorry, that time difference is marginal; it used to see much worse differences. Might as well keep 0.13.X . The commands to revert are above. |
If you want to stay on 0.12.X I will merge; but if you want 0.13.0 revert. Just let me know what you want to do. LGTM |
No problem, Karma in our test is significantly slower... maybe we should try to use gulp in the future. |
chore(update) update some dev dependencies
ok |
Update some dev depencies, using node 0.12.x