Skip to content
This repository was archived by the owner on Sep 20, 2019. It is now read-only.

chore(update) update some dev dependencies #76

Merged
merged 2 commits into from
Oct 30, 2015

Conversation

elesdoar
Copy link
Contributor

Update some dev depencies, using node 0.12.x

"karma-chrome-launcher": "^0.1.8",
"karma-coffee-preprocessor": "^0.2.1",
"karma-coverage": "^0.3.1",
"karma": "0.13.14",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is karma completing fast? One of the reasons it was being held back to 0.12.X was because 0.13.X was slow in grunt. I know in gulp it is fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did test on my PC, Ubuntu 15.10 x64 - Intel Core i5, and it is
reasonably fast, but on travis is slowly, Should I revert?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it is fine. Took 2.413 secs / 2.658 secs fast for me. The only thing that is slow, is travis is a fresh install of binaries of npm and bower.

@nmccready
Copy link
Contributor

@elesdoar no need to revert. lol

@nmccready
Copy link
Contributor

Go back to sha 31422ce

@nmccready
Copy link
Contributor

git rest 31422ce --hard
git push origin --force

@elesdoar
Copy link
Contributor Author

Sorry, test on karma 0.12, You are right, is faster than 0.13.

karma-runner/karma#1608

@nmccready
Copy link
Contributor

No need to be sorry, that time difference is marginal; it used to see much worse differences. Might as well keep 0.13.X . The commands to revert are above.

@nmccready
Copy link
Contributor

If you want to stay on 0.12.X I will merge; but if you want 0.13.0 revert. Just let me know what you want to do. LGTM

@elesdoar
Copy link
Contributor Author

No problem, Karma in our test is significantly slower... maybe we should try to use gulp in the future.

elesdoar added a commit that referenced this pull request Oct 30, 2015
chore(update) update some dev dependencies
@elesdoar elesdoar merged commit bd0abcb into angular-ui:master Oct 30, 2015
@nmccready
Copy link
Contributor

ok

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants