[leafletMapDefaults] Setting {trackResize: false} does not work

[nmccready]

From @adgoncal on May 22, 2015 16:11

I noticed that if I set {trackResize: false} on map defaults, map.options.trackResize is still true and the resize event is still triggered.

Example:

angular.module('SomeModule', []);
angular.module('SomeModule').controller('SomeController', someController);

function someController($scope, leafletData) {
    angular.extend($scope, {
        defaults: {
            trackResize: false
        },
        center: {
            lat: 0,
            lng: 0,
            zoom: 1
        },
        layers: {
            baselayers: { ... }
        }
    });

    leafletData.getMap('mapID').then(function(map) {
        console.log(map.options.trackResize);
    });
}

Looking at the source code, it is clear that only a subset of the possible options are actually used on leafletMapDefaults.setDefaults. Wouldn't it be better to use angular.extend on the defaults that angular-leaflet-directive creates and the options that the user passes to the defaults object?

Something like this:

// ...
setDefaults: function (userDefaults, scopeId) {
    var newDefaults = _getDefaults();

    // Extend the defaults with userDefaults
    newDefaults = angular.extend({}, newDefaults, userDefaults);

    var mapId = obtainEffectiveMapId(defaults, scopeId);
    defaults[mapId] = newDefaults;
    return newDefaults;
}
// ...

Copied from original issue: tombatossals/angular-leaflet-directive#772

[nmccready]

From @jancel on June 25, 2015 16:50

+1

[behboud]

we face the same issue using ionic. On android modal screens will cause the leaflet map to render unexpected views. So: +1

[nmccready]

This is probably a simple fix care to take a look?