This repository was archived by the owner on May 28, 2019. It is now read-only.
Validate the date object using the modelValue #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes one of the two tests that fail when switching to angular#1.3.0-rc.2. The viewValue returns a string value each time but the modelValue returns the object version. The tests also pass for angular 1.2.25.
|
+1 this PR. |
ograycode
added a commit
to ZeroCater/ui-date
that referenced
this pull request
Oct 23, 2014
|
This change worked for me. |
|
Are there any project collaborators around willing to merge this pull request? |
|
Hello kdekooter, I should have had these #99 fixes in a single pull request to simplify things. I believe #99 to be more complete because this seemed to only fix some of the people's problems (probably those mapping date objects directly to the ng-model). The other fix I believe resolves people who are using string formatting, but I have had to submit a fix to angular that should arrive in 1.3.X that will resolve the last of the problems. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes one of the two tests that fail when switching to angular#1.3.0-rc.2. The viewValue returns a string value each time but the modelValue returns the object version. See the docs. The tests also pass for angular 1.2.25.