feat(datepicker): add i18n support for bar buttons in popup #925
Conversation
|
Rebased over current master & added tests. |
|
@pkozlowski-opensource Is there something bothering you about this one? |
|
@bekos oh, I've just missed this one :-( If anything bothers me at the moment is the fact that we start to work on 2 branches in parallel :-) |
|
After 0.6 settles we can have just one branch :-) |
|
Yeh, I'm happy that 0.6.0 is out of the doors, I wanted to get $modal to the world, plus we've got number of bug fixes ready. As for merges, in fact there is also quite a number of changes in JS and previous rebases were a bit painful so we need to find a better way. I'm going to create a new issue for this so we can discuss. But I guess we should just make a new branch for BS2.3 maintanance and switch efforts to BS3 (I mean, work on BS3 off the master). But yeh, let's discuss it together. |
|
@pkozlowski-opensource Sorry for the noise. Can you review this one? Is the problem the merge with bs3 branch? |
|
@bekos sorry for the delay, I'm traveling right now, will be fully operational in 2 weeks time... But I've got access to the internet from time to time so will try to review your 2 PRs in a day or two. |
|
@pkozlowski-opensource OK, thx, I understand. I can do the merging if you want. |
|
@bekos sure, go ahead |
|
Landed as c6ba8d7. |
|
@pkozlowski-opensource Merged as it was a pretty straight-forward change. #924 I will wait for your critique :-) |
No description provided.