This repository was archived by the owner on May 29, 2019. It is now read-only.
Bootstrap3 collapse consecutive transition fix and tidy up #1293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, there would be a case where the two transitions would run as the cancel would asynchronously invoke the reject handler of the transition which would set the currTransition to undefined even when the currTransition has been replaced with a new transition.
|
Awesome @chrisirhc! I was aware of this issue but couldn't pin-point it... Merging this now. |
pkozlowski-opensource
added a commit
that referenced
this pull request
Nov 25, 2013
Bootstrap3 collapse consecutive transition fix and tidy up
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a bug that allowed consecutive transitions. If you click three times quickly, it would break this Bootstrap 3 version. This should be backported to the current collapse though it isn't causing any visible issues.
This is partially because there's a bug in
$transition(due to jqLite) that wouldn't correctly call all the transition end listeners due to angular/angular.js#5109 , when not using jQuery. Yes, it was two bugs in separate places that was making it difficult to solve this one.