bootstrap datepicker configs

[daanporon]

Hi, at the moment the datepickerPopupConfig and datepickerPopupConfig configs are constants. Wouldn't it be better if they where values? You don't need them in any configuration function or provider from what i've seen and i think it would be better if they where modifiable. Also constants can't be overwritten by a factory service, you can only overwrite it by providing your own constant. In my case i want to translate the clear-text, current-text and close-text in my config (so that they are translated in every datepicker i have) and i have a translate service to do translations. So it would be cool if i could overwrite the config by a factory in which i can inject my translate service to do the translations.

kind regards,
Daan

[bekos]

@daanporon I am not really sure if I understand you correctly, but constant's properties are modifiable. Can you please elaborate more?

[daanporon]

The datepickerConfig and datepickerPopupConfig are initialized as constants in the ui-boostrap datepicker plugin. Because they are constants i was unable to override the datepickerPopupConfig in my own module as a factory in which i can translate the currentText, toggleWeeksText, ... using my translator service.

To fix this i changed the datepicker plugin to initialize the datepickerConfig and datepickerPopupConfig as values in stead of constants. This way i was able to override them ... or is there a better way to do this?

@bekos i hope this explanation is more understandable ... :)

[m48u]

Would be nice to change the 'constants' into 'values'! I have the same problem like @daanporon
I know that it is possible to change the text dynamically with e.g. "close-text" attribute in the HTML markup but this way you have to do it for every datepicker in your app again and again. That blows up the HTML part and it's easy to miss one... :(

For me the right place to modify this is in the global config (datepickerPopupConfig) but as long as this is defined as a constant it's only possible to replace values with other constant values. If you try to modify a property with a function or service, you'll fail.

[bekos]

I am not sure I fully follow, but you can override specific options in the module.config, like here: http://plnkr.co/edit/mCyrbiKlMe1Pu2v2masL?p=preview

For some reason the closeText does not work, but this is another bug :-)

[bekos]

About previous comment: closeText is overridden by the datepicker's attribute.

@daanporon @m48u Can you provide a minimum plunker of what you are trying to do? The configs as constant are used throughout the library, and I would like to understand if there is a limitation in this :-)

[m48u]

Hi,
I created a plnkr to demontrate this behavier. While creating it I realized that there is no big difference between 'constant' and 'value' (http://docs.angularjs.org/api/AUTO.$provide#decorator).

http://plnkr.co/edit/ZoJeK9pHev1HH1FppyN7?p=preview

But what I could clearly show is that changing a value explicitly on scope will succeed but changing a constant value within a function won't.
So it seems that I have to use the attribute version to get multi language working because my translation values are the result of a http request which is loaded after app init

[bekos]

Hi @m48u. The case is that datepicker directive does not watch for changes in the constant objects after initialization. On the other hand it is watching for changes in these *-text attributes, but this is something that should be removed anyway :-)

So, there is no way to update the datepicker on the fly by just changing the constant config or the locale, but this is a different issue, that I will try to address when working back on #924.

Thx for taking the time to create the plnkr but I will close for now, since this does not seem relevant to the initial discussion.

[m48u]

Indeed.
But for me setting a watcher on a constant variable is kind of break on definition/convention. A constant should not change its value, therefore we have variables. While thinking about this problem, maybe the usage of directive attributes is already the best solution for i18n since translation isn't ready on app load/init.
Thanks!.

[daanporon]

the way @bekos describes should work by overwriting the properties of the constant ... but as @m48u mentioned a constant shouldn't be changed once it has been defined. The way i was working was by making it a value which can be changed and then overriding it by something like this:

.factory('datepickerPopupConfig', ['$translate', '$rootScope', function($translate, $rootScope) {

        var _popupConfig = {
                dateFormat: 'mediumDate',
                closeOnDateSelection: true,
                appendToBody: false,
                showButtonBar: true,
                currentText: '',
                toggleWeeksText: '',
                clearText: '',
                closeText: ''
            }, _translateConfig = function() {
                _popupConfig.currentText = $translate('common.datepicker.labels.current');
                _popupConfig.toggleWeeksText = $translate('common.datepicker.labels.toggle_weeks');
                _popupConfig.clearText = $translate('common.datepicker.labels.clear');
                _popupConfig.closeText = $translate('common.datepicker.labels.close');
            };

        $rootScope.$on('$translateChangeSuccess', function() {
            _translateConfig();
        });

        _translateConfig();

        return _popupConfig;

    }]);

When datepickerPopupConfig is a constant then i can't do this ... but as you described i will try changing the values from the constant in stead of overwriting the constant by a factory.