Use $watchCollection by default and let the user choose deep watching

[gitnik]

Use $watchCollection by default and then allow the user to use deep watching if he think it's needed. Although with $watchCollection that should rarely ever happen

@aesnyder @nmccready @cthrax input please

[aesnyder]

Can you clarify this statement: Although with $watchCollection that should rarely ever happen

[gitnik]

Using $watchCollection should eliminate the need for deep watching in 99% of all cases as $watchCollection watches the shallow values but not the deep ones. In the case of a collection of models that means it would be same as using the standard $watch on each model

[aesnyder]

ah thanks for that, i'm 100% on board with this

[nmccready]

Sounds great. Who is the assignee?

[gitnik]

I would do this if we all agree on it

[AdamGlass]

Will this address the performance problems i'm seeing where the elements in the array I've got the markers directive pointed at are quite large? Watches on this array are extremely slow -- maybe they're timing out entirely.

[gitnik]

How large are we talking?

[AdamGlass]

At the moment the elements contain the start/end marker locations as well as the polyline data for the route between them. That data is a couple of thousand (lat/long) a piece and some are likely larger. There are a couple of hundred elements too :).

I'm getting the impression that having angular watch a collection like this is a mistake. I should have it watch a smaller collection and for the polylines directive have the path attribute be a function and then play around with static and visible.

[AdamGlass]

i ended up with something like this:

i tried to use the polylines directive but hit issues which i'm going to file. I'm not sure if they represent documentation issues or functional limits

[nmccready]

If you use many polylines you definatley can not have them be editable (thats a google thing). Also adding static/not watching is a performance boost as well.