Uncorrect update

[ximet]

Why marker uncorrect update? I have collection marker, and once I wanna update icon in one marker. But marker icon don't update, because update marker in collection occurs if change langitude and Latitude at marker.

Watch code equals, which compares two models(markers)

ModelKey.prototype.modelKeyComparison = function(model1, model2) {
          var scope;
          scope = this.scope.coords != null ? this.scope : this.parentScope;
          if (scope == null) {
            throw 'No scope or parentScope set!';
          }
          return GmapUtil.equalCoords(this.evalModelHandle(model1, scope.coords), this.evalModelHandle(model2, scope.coords));
};

equalCoords: function(coord1, coord2) {
          return getLatitude(coord1) === getLatitude(coord2) &&  getLongitude(coord1) === getLongitude(coord2);
        }

Maybe, updating not only if changed langitude and Latitude params, but and which changing other param marker, for example icon?
Or how change this compare their?

[nmccready]

Please format your code with README markdown. Use google to search github markdown.

[nmccready]

Use an angular decorator onto MarkersParentModel and override the prototype.modelKeyComparison to make icons accounted for.

[nmccready]

It was done this way to have the least amount of comparisons possible (less overhead). I could add in icon and or more but I think it is better for the user to decide what is important to compare (realizing that the more you do .. the more you slow down watches).

[ximet]

I'm understood you decision, but I think if compare not only was langitude and Latitude thereby give the user this lib choose with many(other) method-equals for compare

[nmccready]

So is the best way forward to have people use decorators? Or should we make an attribute to point to a comparator?

[nmccready]

IE

<ui-gmap-markers comparator="someFunction"> </ui-gmap-markers>

function someFunction(model1,model2){
//compare here
};

[ximet]

I think better(and easy) way make attribute to point to a comparator

[ximet]

Or maybe, better make comporator, which compares two object(marker) on hash-function?(instead of comporator equalCoords)

[ximet]

It's changes input in new version angular google map?

[nmccready]

No I have not worked on it. Have you worked on it?

[ximet]

I can create(Pull request) corparotor, which compares two object on hash-function. But this comporator needed in order to object have method getHashCode()

[nmccready]

ok

[ximet]

Maybe primary you added method GetHashCode for all object?

[nmccready]

For now I would do the easiest solution. Just add icon to the comparator for marker-child-model. It should not be in model-key. It should be overriden in marker-child-model. If people want to take it further; then just add an attribute to allow people to pass a function in to do the comparisons. Or they can just use the decorator pattern instead.