Fix typings in packaged index.d.ts

[dballance]

Convert typescript typings to an external module.

Resolves #44

[wbuchwalter]

Hey Drew,
Thanks for the PR, looks good except one thing:

export var ngRedux: string;
export default ngRedux; 

Here you are just exporting a plain old string as default value. So this is probably not what you wanted to do.

Before we had:

declare module "ngRedux" {      
   export = ngRedux;        
}

this was the old internal module syntax, and it allowed you yo directly access all the interfaces like so:

var myVar: ngRedux.Middleware;

With the new external module syntax, the equivalent would be:

import * as ngRedux from 'ng-redux';

So you can remove the two last lines.
Thanks.

[dballance]

That's an intentional export to match what is exported from the module and to allow direct address of the angular module string.

With the current structure of index.d.ts in this pull request, you can address ng-redux as below.

import * as ngRedux from 'ng-redux';
import { rootReducer } from "./reducers/index";

angular.module('app', [ngRedux.default])
.config(($ngReduxProvider: ngRedux.INgReduxProvider) => {
    $ngReduxProvider.createStoreWith(rootReducer);
  });

The default export closely matches what is exported by the module and allows direct address of the interfaces. I used this pattern in a sample I was building (mostly to learn redux myself) and the above pattern worked for me.

Can see this sample here and it matches up to the PR mention in #44 with redux-ui-router. Does this achieve what you wanted?

[wbuchwalter]

👍
Didn't thought about that, you're right.
Thanks!

[dballance]

👍

Glad I could help!

[wbuchwalter]

I won't be able to release the npm package today, so will do that tomorrow. Sorry for the delay!

[mwilc0x]

awesome, thank you @dballance && @wbuchwalter! 👍