Docker Integration

[JeremyMarshall]

I merged my changes from my previous Docker PR (closed) into https://github.com/angular-fullstack/generator-angular-fullstack/tree/docker-integration

This does the yo angular-fullstack:docker as before.

There is also a git submodule in ci/angular-fullstack-dockerfile pointing back to the docker repo https://github.com/angular-fullstack/angular-fullstack-dockerfile and a script inside it to branch this repo for building in hub.docker. Hopefully this can be done automatically with some CI after a release.
There is work to add the hub.docker automated build as I don't have access to the git repo to create it at https://hub.docker.com/u/generatorangularfullstack/ - This currently points to my personal fork and I don't think it can be changed without deleting and recreating in hub.docker

[Awk34]

Please conform to the Contributing Guidelines.

[Awk34]

Do you mind if I tweak your commits?

[JeremyMarshall]

not at all. I can take them back and resubmit if you haven't done anything

On Wed, Jun 8, 2016 at 12:04 AM, Andrew Koroluk notifications@github.com
wrote:

Do you mind if I tweak your commits?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1959 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ACjgyLWnjrGI-m3hBSxemjF1OIsANitzks5qJXp-gaJpZM4Iv3ya
.

[AmirGilboa]

Can you please explain what is it doing, and why should we use it?
Thanks.

[Awk34]

@AmirGilboa https://www.docker.com/

[JeremyMarshall]

I moved the submodule and fixed the submodule to use the new path and I forgot to add the version number to the docker FROM statement. It uses the main version number and tracks with it when run

[JeremyMarshall]

@AmirGilboa This enhancement is the first step towards deploying a whole application stack (including load-balancers, multiple app servers and databases) to AWS or any other cloud provider. These app servers can be scaled up and down as demand changes
This change in particular uses a standard node.js provided build and tracks the npm changes in the generator to cut down on build times. If apps using the Dockerfile use the https://hub.docker.com/ automated build infrastructure then they will also be rebuilt on upstream changes

[AmirGilboa]

Sounds great, thanks for doing this. I just did some reading on Docker, have never used it before. It's a great feature for the generator.

[corporationsruleyourmom]

Very interested in seeing this happen as both Openshift and Heroku seem to not be deploying properly!

[aabm00]

Yes. it looks that now we can deploy the application to Openshift. Some way to solve this problem?

Thanks

[JeremyMarshall]

I added some wiki information.
I have some fixes for circleci waiting to push as I was hoping to update the docker repo from it. Unfortunately it is failing some tests and deployment steps can't go until all the tests pass