Unable to convert from TSLint to ESLint with tslint-to-eslint-config 2.7.0

[mkurte]

Hi guys,

in this issue I described that I am not able to run the command to migrate from tslint to eslint.

When I type ng g @angular-eslint/schematics:convert-tslint-to-eslint PROJECTNAME and check the defaults I get this error:

There was a critical error when trying to inspect your tslint.json:

env: node: No such file or directory

I'm running this command on a mac, in a multiple projects workspace.
My project is in the root folder, the tslint.json file too. Is there something I am missing?

If I type npx tslint --print-config {PATH_TO_YOUR_TSLINT_JSON_HERE} as suggested I get a new tslint.json config, but that one doesn't work too.

Many thanks in advance,
Matthias

[mkurte]

My tslint.json looks like this:

{
  "rulesDirectory": [
    "node_modules/codelyzer",
    "node_modules/rxjs-tslint"
  ],
  "rules": {
    "callable-types": true,
    "class-name": true,
    "comment-format": [
      true,
      "check-space"
    ],
    "curly": true,
    "deprecation": {
      "severity": "warning"
    },
    "eofline": true,
    "forin": true,
    "import-blacklist": [],
    "import-spacing": true,
    "indent": [
      true,
      "spaces"
    ],
    "interface-over-type-literal": true,
    "label-position": true,
    "max-line-length": [
      true,
      160
    ],
    "member-access": false,
    "member-ordering": [
      true,
      {
        "order": [
          "public-static-field",
          "public-instance-field",
          "private-static-field",
          "private-instance-field",
          "constructor",
          "public-static-method",
          "public-instance-method",
          "private-static-method",
          "private-instance-method"
        ]
      }
    ],
    "no-arg": true,
    "no-bitwise": true,
    "no-console": true,
    "no-construct": true,
    "no-debugger": true,
    "no-duplicate-variable": true,
    "no-empty": false,
    "no-empty-interface": true,
    "no-eval": true,
    "no-inferrable-types": [true, "ignore-params", "ignore-properties"],
    "no-shadowed-variable": true,
    "no-string-literal": false,
    "no-string-throw": true,
    "no-switch-case-fall-through": true,
    "no-trailing-whitespace": true,
    "no-unused-expression": true,
    "no-var-keyword": true,
    "object-literal-sort-keys": false,
    "one-line": [
      true,
      "check-open-brace",
      "check-catch",
      "check-else",
      "check-whitespace"
    ],
    "prefer-const": true,
    "quotemark": [
      true,
      "single"
    ],
    "radix": true,
    "semicolon": [
      true,
      "always"
    ],
    "triple-equals": [
      true,
      "allow-null-check"
    ],
    "typedef-whitespace": [
      true,
      {
        "call-signature": "nospace",
        "index-signature": "nospace",
        "parameter": "nospace",
        "property-declaration": "nospace",
        "variable-declaration": "nospace"
      }
    ],
    "unified-signatures": true,
    "variable-name": false,
    "whitespace": [
      true,
      "check-branch",
      "check-decl",
      "check-operator",
      "check-separator",
      "check-type"
    ],

    "directive-selector": [true, "attribute", "p1", "camelCase"],
    "component-selector": [true, "element", "p1", "kebab-case"],
    "no-inputs-metadata-property": true,
    "no-outputs-metadata-property": true,
    "no-host-metadata-property": true,
    "no-input-rename": true,
    "no-output-rename": true,
    "use-lifecycle-interface": true,
    "use-pipe-transform-interface": true,
    "component-class-suffix": true,
    "directive-class-suffix": true,
    "rxjs-collapse-imports": true,
    "rxjs-pipeable-operators-only": true,
    "rxjs-no-static-observable-methods": true,
    "rxjs-proper-imports": true
  }
}

[mkurte]

Update: Even if I create a new app with Angular CLI 11 I get the same error:

ng new my-app
cd my-app
ng add @angular-eslint/schematics
ng g @angular-eslint/schematics:convert-tslint-to-eslint --defaults

Result:

    INFO: We are now installing the "tslint-to-eslint-config" package into a tmp directory to aid with the conversion

    This may take a minute or two...


There was a critical error when trying to inspect your tslint.json:

env: node: No such file or directory

[JamesHenry]

@mkurte are you replacing the part which says to put the path to your actual tslint.json i.e. the placeholder {PATH_TO_YOUR_TSLINT_JSON_HERE} - it's not clear from your description.

E.g. if your tslint.json were in the current directory you would run

npx tslint --print-config ./tslint.json

[mkurte]

I am in the directory where my tslint.json lives and enter the command

ng g @angular-eslint/schematics:convert-tslint-to-eslint projectname

That leads to the error.

If I type npx tslint --print-config ./tslint.json I get

{
  "extends": [],
  "jsRules": {},
  "linterOptions": {},
  "rules": {
    "callable-types": {
      "ruleArguments": [],
      "ruleSeverity": "error"
    },
    "class-name": {
      "ruleArguments": [],
      "ruleSeverity": "error"
    },
    "comment-format": {
      "ruleArguments": [
        "check-space"
      ],
      "ruleSeverity": "error"
    },
    "curly": {
      "ruleArguments": [],
      "ruleSeverity": "error"
    },
    "deprecation": {
      "ruleSeverity": "warning"
    },
    "eofline": {
      "ruleArguments": [],
      "ruleSeverity": "error"
    },
    "forin": {
      "ruleArguments": [],
      "ruleSeverity": "error"
    },
    "import-blacklist": {
      "ruleSeverity": "error"
    },
    "import-spacing": {
      "ruleArguments": [],
      "ruleSeverity": "error"
    },
    "indent": {
      "ruleArguments": [
        "spaces"
      ],
      "ruleSeverity": "error"
    },
    "interface-over-type-literal": {
      "ruleArguments": [],
      "ruleSeverity": "error"
    },
    "label-position": {
      "ruleArguments": [],
      "ruleSeverity": "error"
    },
    "max-line-length": {
      "ruleArguments": [
        160
      ],
      "ruleSeverity": "error"
    },
    "member-access": {
      "ruleArguments": [],
      "ruleSeverity": "off"
    },
    "member-ordering": {
      "ruleArguments": [
        {
          "order": [
            "public-static-field",
            "public-instance-field",
            "private-static-field",
            "private-instance-field",
            "constructor",
            "public-static-method",
            "public-instance-method",
            "private-static-method",
            "private-instance-method"
          ]
        }
      ],
      "ruleSeverity": "error"
    },
    "no-arg": {
      "ruleArguments": [],
      "ruleSeverity": "error"
    },
    "no-bitwise": {
      "ruleArguments": [],
      "ruleSeverity": "error"
    },
    "no-console": {
      "ruleArguments": [],
      "ruleSeverity": "error"
    },
    "no-construct": {
      "ruleArguments": [],
      "ruleSeverity": "error"
    },
    "no-debugger": {
      "ruleArguments": [],
      "ruleSeverity": "error"
    },
    "no-duplicate-variable": {
      "ruleArguments": [],
      "ruleSeverity": "error"
    },
    "no-empty": {
      "ruleArguments": [],
      "ruleSeverity": "off"
    },
    "no-empty-interface": {
      "ruleArguments": [],
      "ruleSeverity": "error"
    },
    "no-eval": {
      "ruleArguments": [],
      "ruleSeverity": "error"
    },
    "no-inferrable-types": {
      "ruleArguments": [
        "ignore-params",
        "ignore-properties"
      ],
      "ruleSeverity": "error"
    },
    "no-shadowed-variable": {
      "ruleArguments": [],
      "ruleSeverity": "error"
    },
    "no-string-literal": {
      "ruleArguments": [],
      "ruleSeverity": "off"
    },
    "no-string-throw": {
      "ruleArguments": [],
      "ruleSeverity": "error"
    },
    "no-switch-case-fall-through": {
      "ruleArguments": [],
      "ruleSeverity": "error"
    },
    "no-trailing-whitespace": {
      "ruleArguments": [],
      "ruleSeverity": "error"
    },
    "no-unused-expression": {
      "ruleArguments": [],
      "ruleSeverity": "error"
    },
    "no-var-keyword": {
      "ruleArguments": [],
      "ruleSeverity": "error"
    },
    "object-literal-sort-keys": {
      "ruleArguments": [],
      "ruleSeverity": "off"
    },
    "one-line": {
      "ruleArguments": [
        "check-open-brace",
        "check-catch",
        "check-else",
        "check-whitespace"
      ],
      "ruleSeverity": "error"
    },
    "prefer-const": {
      "ruleArguments": [],
      "ruleSeverity": "error"
    },
    "quotemark": {
      "ruleArguments": [
        "single"
      ],
      "ruleSeverity": "error"
    },
    "radix": {
      "ruleArguments": [],
      "ruleSeverity": "error"
    },
    "semicolon": {
      "ruleArguments": [
        "always"
      ],
      "ruleSeverity": "error"
    },
    "triple-equals": {
      "ruleArguments": [
        "allow-null-check"
      ],
      "ruleSeverity": "error"
    },
    "typedef-whitespace": {
      "ruleArguments": [
        {
          "call-signature": "nospace",
          "index-signature": "nospace",
          "parameter": "nospace",
          "property-declaration": "nospace",
          "variable-declaration": "nospace"
        }
      ],
      "ruleSeverity": "error"
    },
    "unified-signatures": {
      "ruleArguments": [],
      "ruleSeverity": "error"
    },
    "variable-name": {
      "ruleArguments": [],
      "ruleSeverity": "off"
    },
    "whitespace": {
      "ruleArguments": [
        "check-branch",
        "check-decl",
        "check-operator",
        "check-separator",
        "check-type"
      ],
      "ruleSeverity": "error"
    },
    "directive-selector": {
      "ruleArguments": [
        "attribute",
        "p1",
        "camelCase"
      ],
      "ruleSeverity": "error"
    },
    "component-selector": {
      "ruleArguments": [
        "element",
        "p1",
        "kebab-case"
      ],
      "ruleSeverity": "error"
    },
    "no-inputs-metadata-property": {
      "ruleArguments": [],
      "ruleSeverity": "error"
    },
    "no-outputs-metadata-property": {
      "ruleArguments": [],
      "ruleSeverity": "error"
    },
    "no-host-metadata-property": {
      "ruleArguments": [],
      "ruleSeverity": "error"
    },
    "no-input-rename": {
      "ruleArguments": [],
      "ruleSeverity": "error"
    },
    "no-output-rename": {
      "ruleArguments": [],
      "ruleSeverity": "error"
    },
    "use-lifecycle-interface": {
      "ruleArguments": [],
      "ruleSeverity": "error"
    },
    "use-pipe-transform-interface": {
      "ruleArguments": [],
      "ruleSeverity": "error"
    },
    "component-class-suffix": {
      "ruleArguments": [],
      "ruleSeverity": "error"
    },
    "directive-class-suffix": {
      "ruleArguments": [],
      "ruleSeverity": "error"
    },
    "rxjs-collapse-imports": {
      "ruleArguments": [],
      "ruleSeverity": "error"
    },
    "rxjs-pipeable-operators-only": {
      "ruleArguments": [],
      "ruleSeverity": "error"
    },
    "rxjs-no-static-observable-methods": {
      "ruleArguments": [],
      "ruleSeverity": "error"
    },
    "rxjs-proper-imports": {
      "ruleArguments": [],
      "ruleSeverity": "error"
    }
  },
  "rulesDirectory": [
    "/Users/matthiaskurte/src/planone/frontend/app/node_modules/codelyzer",
    "/Users/matthiaskurte/src/planone/frontend/app/node_modules/rxjs-tslint"
  ]
}

This is my directory structure:

.                                
├── README.md                    
├── angular.json                 
├── karma.global.conf.js         
├── ngsw-config.json             
├── package-lock.json            
├── package.json                 
├── projects                     
│   └── libs                     
├── run-tests.sh                 
├── server.ts                    
├── src                          
│   ├── app                      
│   ├── assets                   
│   ├── environments             
│   ├── i18n                     
│   ├── index.html               
│   ├── karma.conf.js            
│   ├── main.server.ts           
│   ├── main.ts                  
│   ├── polyfills.ts             
│   ├── styles                   
│   ├── test.ts                  
│   ├── tsconfig.app.json        
│   ├── tsconfig.server.json     
│   ├── tsconfig.spec.json       
│   └── typings.d.ts             
├── tsconfig.e2e.json            
├── tsconfig.json                
├── tsconfig.spec.json           
├── tslint.json                  
├── typedoc.json                 
└── webpack.server.config.js     

[JamesHenry]

Thanks @mkurte that's useful.

What happens if you run:

node --version

and

npm --version

?

After a quick search env: node: No such file or directory seems to be coming up for folks (unrelated to angular-eslint) who have unusual/malformed nodejs installations, so the above might give us a clue on that...

[mkurte]

I use nvm and have currently installed:

node -v
v12.18.0

npm -v
7.16.0

[KyDenZ]

I have the same problem with a project containing several applications

Update: I have the impression that the problem is with the package tslint-to-eslint-config with the last version (not working with 2.7.0, working with 2.6.0)

[mkurte]

@KyDenZ Yep, thanks a lot. Converting a tslint.json file to .eslintrs.js with tslint-to-eslint-config@2.6.0 works for me too. Should we close that issue here?

[KyDenZ]

@mkurte We could fix it by fixing the version in the schematics package

[mkurte]

My quick fix was to manually install tslint-to-eslint-config in version 2.6.0 as a dev dependency, migrate and then uninstall it again:

ng add @angular-elements/schematics
npm install --save-dev tslint-to-eslint-config@2.6.0
ng g @angular-eslint/schematics:convert-tslint-to-eslint myproject
npm uninstall --save-dev tslint-to-eslint-config

[KyDenZ]

Yes we can do like that! Thank you

[JamesHenry]

Thanks for looking into this more and reporting it on typescript-eslint/tslint-to-eslint-config#1159

I was mightily confused why 3 separate people were suddenly reporting installation related issues on the same day, but an issue/change in tslint-to-eslint-config explains that.

I'll wait to hear back from Josh on this before changing anything about angular-eslint, and direct people here in the meantime if anyone else runs into it