fix(index-file): fixed the double quote issue #849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asollberger
commented
May 9, 2025
asollberger
commented
- fix for issue rendering incorrect script tags in index #836
- also fixed the body tag replacement string when attaching a class to body f.ex. it would not find it and add the esms-options
- also fixed the body replacement string When attaching a class to body f.ex. <body class="mat-typography"> it would not find it and add the esms-options
2 tasks
|
@manfredsteyer the function updateScriptTags does not use the parameters mainName or polyfillsName anymore. I could remove them as well and refactor the few places where it's called unless you have plans to reactivate that behavior again. |
| '<script type="module" src="$1"></script>' | ||
| ); | ||
| indexContent = indexContent.replace( | ||
| /<script src="(.*?main.*?)><\/script>/, | ||
| /<script src="(.*?main.*?)".*?><\/script>/, |
There was a problem hiding this comment.
If other builders setup other script tag attributes it will break them. Ain't there a way to parse the HTML node as a key value data structure easy to manipulate? 🤔
There was a problem hiding this comment.
I like the idea, will have to tinker with the DOMParser and the XMLSerializer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.