1st attempt at i18n support #411
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This is a first attempt for basic support of i18n in native federation.
The main restriction with my implementation is that libraries can't have localizations to inline, because I did nothing with the build adapter to support it.
What I did, is that
FederationOptionshas a locales array, which is assumed to be an array ofoutputPathsubfolders each with their own build output.Each locale's folder in turn
I'm still in process of testing it, but I wanted to get your feedback asap.
I also believe I might have some extra steps to support the dev server mode, but I haven't really looked into it yet.
closes #413