share() does not work if used in a yarn workspace

[janhommes]

Yarn workspaces use node_modules resolution algorithm to allow a mono-repository structure. Mostly all modules are placed on the root level so that they can be resolved by any other package in the monorepo. The currently used approach to determine the secondary entry points leads to an error when used in such a setup, as the node_modules resolving is not using the same resolving mechanism. Mostly an error is thrown that the file could not be found, as it might only exist on a node_modules folder some level up.

I guess this line needs to be considered

module-federation-plugin/libs/mf/src/utils/share-utils.ts

Line 86 in 790d0e4

const libPath = path.join(path.dirname(packagePath), 'node_modules', key);

It maybe should use require.resolve to use the same resolving algorithm like node_modules.

[Markiewic]

Same issue!

I use Nx monorepo workspace which doesn't create local node_modules folders, but uses only the project's global node_modules. So when the plugin tryies to resolve secondary entry points, it looks them relatively package.json file, which in my case is not located next to the node_modules folder. The path that the plugin is trying to scan looks like this:

{projectFolder}/apps/{appName}/node_modules/@angular/common

{projectFolder}/node_modules <-- true node_modules folder is right there

So share falls into:

ENOENT: no such file or directory, scandir {projectFolder}/apps/{appName}/node_modules/@angular/common

[manfredsteyer]

The new Angular Package Format now defines an official way of declaring secondary entry points. It is implemented in version 14.3 of this plugin. Can you please try it out?

[Markiewic]

Now it works fine! Thanks.