Add the XRController sample.

[hj-cpdm-son]

• This sample includes XRController assets (prefab, animation, scripts, etc.).
• If you use this sample, import it with the URP project.
• It will be updated when new Controller assets are released.

[salarkhan-google]

Everything seems fine. Except that shader graph should not really be used since then the package would need to depend on it, and the shader should work on both URP and built in rendering pipeline. Also I noticed for the left eye the controllers render fine but for the right eye they seem to be offset. Please check the screenshot. The two spheres were attached to the controller prefab for reference, so it indicates that the transform is still in the appropriate place but the mesh is not rendering as expected for the right eye.

[salarkhan-google]

Update: I used Unity standard material and then it rendered correctly for right eye. Please fix any shader issues that might be causing offset rendering for right eye or you can just a Unity standard shader and create a new material and assign the textures to it.

[hj-cpdm-son]

Hello
I updated the controller shader. As you mentioned, the asset does not use Shader Graph;
If a user is working with a non-URP project, they can simply switch the shader to Standard.

[salarkhan-google]

Please make default shader built-in RP Standard since this package itself does not depend on URP. If user imports this project into URP project, they would know that they need to convert shaders. Other samples in this package also use the built-in RP Standard Material.

Please use solid Color for camera clear flags and set the background color to (0, 0, 0, 0) to ensure it uses passthrough.

Other than this it looks good to go.

[salarkhan-google]

Sorry one final change. I noticed the controller was way too down. This is because your camera y offset is not 0 which sets the session camera origin a little higher, and therefore the controllers local position positions being set in XRRig are more down relative to the Camera Origin. To fix this, please make the controllers child objects of Camera Offset. This way the controller trackers share the same origin as the camera.

[salarkhan-google]

Please add apache license header to source file. You can check examples of our other source files. Please ensure to use your organization name.

[LevanaChen]

Hi,
Thanks for the contribution. One more minor change here. Could you remove the redundant "Controller" folder so all types of assets folders are directly under the sample root?

[salarkhan-google]

Could you remove the redundant "Controller" folder and bring all its content under "XRController" folder so all types of assets folders are directly under the sample root?

[salarkhan-google]

Sorry forgot to mention this, I just recently found out. The Contribution License Agreement (CLA) requires that new files added to a Google-maintained open source project should include a license header with a "Google LLC" copyright notice, whether the file is created by a Googler or Non-Googler.

From a legal perspective, leaving "Copyright Google LLC" in the headers does not affect the contributors' rights.

Therefore, please change company name to Google LLC.