Skip to content

Remove moduleScopePlugin that restricted the relative imports #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2017

Conversation

ehaivala
Copy link

Remove moduleScopePlugin that restricted the relative imports into the created
apps src directory.

Refs ANDERS-275

Remove moduleScopePlugin that restricted the relative imports into the created
apps src directory.
@ehaivala ehaivala requested a review from suutari-ai October 11, 2017 05:48
@frwickst
Copy link

As we talked about different projects in the same repo, this is a hint that there probably exists more than one project in the repo ;) Not saying that it is anything bad or that anything has to change, just found it a bit peculiar :)

@ehaivala
Copy link
Author

Something like that. In this case we need/want to import from the common component library that exists outside the app created by create-react-app and these changes allow that.

@frwickst
Copy link

frwickst commented Oct 11, 2017

Yup, I guessed that was the reason. If it was its own package however, then there would be no need to import like that, then it would just be import { myFancyFeature } from 'my-fancy-package, and not worry about relative imports and such 🙂 But I do get the appeal of having everything in one place.

@suutari-ai suutari-ai merged commit 21f8abb into master Oct 11, 2017
@suutari-ai suutari-ai deleted the remove_module_scope_restriction branch October 11, 2017 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants