Update readers.py in cases where the next record contains Empty list instead of None #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
wjsi
reviewed
Apr 21, 2025
odps/readers.py
Outdated
| @@ -360,6 +360,8 @@ def __next__(self): | |||
| values = self._readline() | |||
| if values is None: | |||
| raise StopIteration | |||
| if len(values) == 0: | |||
There was a problem hiding this comment.
Is it possible to merge this condition with the previous one?
There was a problem hiding this comment.
You mean like?
if values is None or len(values) == 0:
raise StopIterationthe len part will throw a TypeError for objects that are truly NoneType
There was a problem hiding this comment.
This will not happen if values is None as Python will not evaluate the second expression.
There was a problem hiding this comment.
You are right @wjsi . Sorry for my mistake. Indeed it is possible to merge the condition to the previous one.
There was a problem hiding this comment.
I have updated the code to reflect the changes in this discussion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle cases in
readers.pywhere the next record is an empty list instead ofNoneOtherwise, it will throw a ValueError of
ValueError: The values set to records are against the schema, expect len 1, got len 0