Skip to content

Reworked structure of original plugin #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 6, 2018
Merged

Reworked structure of original plugin #1

merged 4 commits into from
Aug 6, 2018

Conversation

PudottaPommin
Copy link
Member

@PudottaPommin PudottaPommin commented Jul 29, 2018

Reworked structure and modified functionality of original plugin.
Languages are loaded from code snippets/samples/blocks.
From list of present languages is build menu. If user has no language selected, preselected is that, which is set default in configuration. If there is no code sample for default/current language, plugin tries to get 1st language available and preselect that.

In case, user selects C# and there is no code example for C#, same logic is used as with no selected language.

It's desired, if you can test it too. I have found none bugs or broken views.

Ngrok tunnel on my running instance - works until tunnel is cancelled

Preview how it looks

It's grid 3xN columns/rows
image

With less languages
image

If there are no codeblocks, this is menu item is hidden
image

@leios
Copy link
Member

leios commented Aug 5, 2018

I remember this being mostly completed a few days ago, but I don't remember if it's completely done or not. What's the status?

@PudottaPommin
Copy link
Member Author

Waiting for revision basically.
If someone wants to test it independently thats option too.

It's done in terms of design on standard devices what I could test. If there will be broken design on something that would need to be fixed later.

@leios
Copy link
Member

leios commented Aug 5, 2018

Ok. I think the AAA looks better like this. That said, it's a huge formatting change to the AAA, so I feel like we should get outside opinions (@julianschacher @Butt4cak3 @Gathros )

To see the changes, just point your book.json link to @MichalHanajik's fork and gitbook install && gitbook serve

@leios
Copy link
Member

leios commented Aug 6, 2018

Alright, there is not more discussion happening here and it's a positive change. I'm keen to merge it now.

@leios leios merged commit a594ae1 into algorithm-archivists:master Aug 6, 2018
@june128
Copy link
Member

june128 commented Aug 6, 2018

I couldn't review the PR, but the visual changes and the bug fix, which come along with them, are a big improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants