-
-
Notifications
You must be signed in to change notification settings - Fork 359
master -> main #953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
master -> main #953
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, keep in mind you will need to be quick about it running and we may need to merge another PR right after to trigger the deployments since when this is merged the main branch wont exist
# Domain coloring | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Contex on removal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were 2 *.bak
files that were not meant to be committed. It was due to a temporary state in aspell
for spell-checking I think
Flood fill is a method that is surprisingly useful in a large number of different situations and keeps finding me wherever I go. | ||
When I was completing my PhD, I had an idea to track superfluid vortices by using flood fill as a way to help mask out unnecessary features of the simulation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Context on removal?
Co-authored-by: Dimitri Belopopsky <ShadowMitia@users.noreply.github.com>
Ok, so to be clear, the best thing to do is:
|
If the branch is renamed successfully, all open PRs targets will be updated automatically as well. |
I think the only thing we needed to change was
deploy.yml
, but I took the opportunity to also remove old travis infrastructure